Add documentation about auth for the collector #605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jpkrohling
requested review from
austinlparker,
flands,
jparsana and
mtwo
as code owners
Member
Author
|
@alolita, @gramidt, @pavankrish123, would you please review this one? This is an initial draft that can be expanded later. |
gramidt
approved these changes
Jun 10, 2021
Member
gramidt
left a comment
gramidt
left a comment
There was a problem hiding this comment.
Just a minor nit and everything else looks amazing. Great work!
LGTM!
mtwo
approved these changes
Jun 11, 2021
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Member
Author
|
I'm marking this as ready, as the OAuth2 client authenticator extension has been approved. |
This was referenced Sep 14, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please, do not merge until open-telemetry/opentelemetry-collector#3369 is merged.
Signed-off-by: Juraci Paixão Kröhling [email protected]