Reinstate website docs for auth #4041
Conversation
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
|
@austinlparker, would you be available for a review? |
|
@jpkrohling can you explain why these changes disappeared? |
|
Apparently, I opened a PR against the website repository (open-telemetry/opentelemetry.io#605) instead of opening one here. At some point, an automated pull request (open-telemetry/opentelemetry.io#649) between this repository here and the website repo got rid of the collector doc files I added. |
|
@austinlparker, how can I get a build of the website locally with the files from this PR? I wanted to validate whether the check-links failures are real. |
|
You'd need to sync the changes locally and run the build from the website repo. |
|
Would those check link tests ever pass? They're looking for things in the website repo. Glancing over them, they look fine, I'd just merge and I can edit the PR on the website side if needed. |
Oh my, this is precisely the sort of issue that open-telemetry/opentelemetry.io#730 is going to prevent. Note that we're in the process of migrating the collector docs back into the website repo (opentelemetry.io#731), so @jpkrohling et al., could we stop submitting doc PRs here? Once opentelemetry.io#731 is merged, than I'd be glad to reinstate open-telemetry/opentelemetry.io#649 for you (@jpkrohling), if you'd like. Apologies for the turmoil as we work our way through opentelemetry.io#731. |
|
Can we make sure that open-telemetry/opentelemetry.io#731 includes the content being re-added in this PR? That will make this one moot I believe. |
That's the end result we want, but I'd rather handle the addition separately, and get #4042 merged into this repo ASAP. |
|
Thanks for the heads-up! I'm closing this in favor of the the having the docs in the website's repo again. |
4 participants
This change reinstates the website docs for the auth capabilities, resolving open-telemetry/opentelemetry.io#673 .
Signed-off-by: Juraci Paixão Kröhling [email protected]