feat(otlp): add build() on base exporter builders to auto-select from env#3394
feat(otlp): add build() on base exporter builders to auto-select from env#3394scottgerring wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
…sport from env/features
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3394 +/- ##
=======================================
+ Coverage 82.7% 83.1% +0.4%
=======================================
Files 128 128
Lines 24811 24841 +30
=======================================
+ Hits 20526 20652 +126
+ Misses 4285 4189 -96 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Lets add a changelog, and see if we can leverage this in the otlp examples in the repo? |
lalitb
left a comment
There was a problem hiding this comment.
Thanks, LGTM once changelog and tests are added.
A nice follow-up could be to support something like .with_endpoint("...").build() directly on the base builder, without having to pick with_tonic() or with_http() first. That way users can set things like endpoint or timeout in code while still letting the transport get picked automatically.
6ec7d53 to
0341d48
Compare
|
@cijothomas @lalitb feedback addressed should be good to go |
Fixes #3208.
With this change, a user can simply call
build()on an exporter instead of having to explicitly choose tonic or http. Because we are only implementing this forNoExporterBuilderSetthis doesn't cause ambiguity with the existing building pattern.Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes