chore: address review comments

Author: scottgerring

opentelemetry-otlp/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## vNext
 
+- Add `build()` directly on `SpanExporterBuilder`, `MetricExporterBuilder`, and `LogExporterBuilder`
+  (before selecting a transport), which auto-selects the transport based on the
+  `OTEL_EXPORTER_OTLP_PROTOCOL` environment variable or enabled features.
+  [#3394](https://github.com/open-telemetry/opentelemetry-rust/pull/3394)
 - **Breaking** Removed `ExportConfig`, `HasExportConfig`, `with_export_config()`, `HasTonicConfig`, `HasHttpConfig`, `TonicConfig`, and `HttpConfig` from public API.
   Use the public `WithExportConfig`, `WithTonicConfig`, and `WithHttpConfig` trait methods instead, which remain unchanged.
 - The gRPC/tonic OTLP exporter's build method now returns an error for all signals (traces, metrics, logs) when

opentelemetry-otlp/examples/basic-otlp/src/main.rs

@@ -26,7 +26,6 @@ fn get_resource() -> Resource {
 
 fn init_traces() -> SdkTracerProvider {
     let exporter = SpanExporter::builder()
-        .with_tonic()
         .build()
         .expect("Failed to create span exporter");
     SdkTracerProvider::builder()
@@ -37,7 +36,6 @@ fn init_traces() -> SdkTracerProvider {
 
 fn init_metrics() -> SdkMeterProvider {
     let exporter = MetricExporter::builder()
-        .with_tonic()
         .build()
         .expect("Failed to create metric exporter");
 
@@ -49,7 +47,6 @@ fn init_metrics() -> SdkMeterProvider {
 
 fn init_logs() -> SdkLoggerProvider {
     let exporter = LogExporter::builder()
-        .with_tonic()
         .build()
         .expect("Failed to create log exporter");
 

opentelemetry-otlp/src/logs.rs

@@ -166,6 +166,20 @@ impl LogExporter {
     }
 }
 
+#[cfg(test)]
+#[cfg(any(feature = "grpc-tonic", feature = "http-proto", feature = "http-json"))]
+mod tests {
+    use crate::LogExporter;
+
+    #[test]
+    fn build_with_default_transport() {
+        // Verify that `LogExporter::builder().build()` succeeds
+        // when at least one transport feature is enabled.
+        let result = LogExporter::builder().build();
+        assert!(result.is_ok(), "build() should succeed: {:?}", result.err());
+    }
+}
+
 impl opentelemetry_sdk::logs::LogExporter for LogExporter {
     async fn export(&self, batch: LogBatch<'_>) -> OTelSdkResult {
         match &self.client {

opentelemetry-otlp/src/metric.rs

@@ -272,6 +272,20 @@ impl MetricExporter {
     }
 }
 
+#[cfg(test)]
+#[cfg(any(feature = "grpc-tonic", feature = "http-proto", feature = "http-json"))]
+mod build_tests {
+    use crate::MetricExporter;
+
+    #[test]
+    fn build_with_default_transport() {
+        // Verify that `MetricExporter::builder().build()` succeeds
+        // when at least one transport feature is enabled.
+        let result = MetricExporter::builder().build();
+        assert!(result.is_ok(), "build() should succeed: {:?}", result.err());
+    }
+}
+
 #[cfg(test)]
 mod tests {
     use super::*;

opentelemetry-otlp/src/span.rs

@@ -169,6 +169,20 @@ impl SpanExporter {
     }
 }
 
+#[cfg(test)]
+#[cfg(any(feature = "grpc-tonic", feature = "http-proto", feature = "http-json"))]
+mod tests {
+    use crate::SpanExporter;
+
+    #[test]
+    fn build_with_default_transport() {
+        // Verify that `SpanExporter::builder().build()` succeeds
+        // when at least one transport feature is enabled.
+        let result = SpanExporter::builder().build();
+        assert!(result.is_ok(), "build() should succeed: {:?}", result.err());
+    }
+}
+
 impl opentelemetry_sdk::trace::SpanExporter for SpanExporter {
     async fn export(&self, batch: Vec<SpanData>) -> OTelSdkResult {
         match &self.client {