docs(website): support GH page links to canonical src#2421
Merged
dyladan merged 4 commits intoAug 27, 2021
Conversation
6 tasks
Member
That sounds great! Keeping the website docs up to date isn't a hard task, but it is one more thing that needs to be remembered and can be forgotten each time we update the docs. |
Contributor
Author
|
Hi all. Anything to be done before this can be approved and merged? |
mtwo
approved these changes
Aug 25, 2021
dyladan
approved these changes
Aug 27, 2021
Member
|
We need another approver before we can merge |
Member
|
The browser test failure is completely unrelated. I'm going to merge. |
This was referenced Sep 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to open-telemetry/opentelemetry.io#542
/cc @carlosalberto @mtwo @shelbyspees @austinlparker
While I can't (currently) show you a preview of this PR, you can see the corresponding change for OTel Java in action by clicking on the Edit this page and related links, from https://opentelemetry.io/docs/java/ and it's subpages.
@dyladan @obecny @vmarchaud: I see that this repo doesn't yet have a
docs-updateGitHub action. If you prefer, I can link OTel JSwebsite_docsto the OTel website via a git submodule -- similar to what I did for Go in Link to OTel Go website_docs via submodule - open-telemetry/opentelemetry.io#690. That way you won't need to submit website_docs PRs.Context: #2051