Skip to content

Conversation

@chalin
Copy link
Contributor

@chalin chalin commented Aug 18, 2021

This is a first illustration of #661 for open-telemetry/opentelemetry-go, which doesn't yet have a docs-update GitHub action. In fact, this relieves OTel Go maintainers from pushing doc update PRs to this repo, and so they won't require a docs-update GitHub action.

Aside from updated date/time stamps, there are no changes to the generated site files:

$ cd public && git diff -I '^<meta \w+="[^"]*(date|time)' -I '>Last modified' -- . ':(exclude)*.xml'
$

Preview: https://deploy-preview-690--opentelemetry.netlify.app/docs/go/

/cc @carlosalberto @shelbyspees

@chalin chalin added the docs:CI/infra CI & infrastructure label Aug 18, 2021
@chalin chalin requested a review from a team August 18, 2021 13:51
@chalin
Copy link
Contributor Author

chalin commented Aug 18, 2021

Note: once open-telemetry/opentelemetry-go#2189 is merged, the page GitHub links, like Edit this page, will point to the OTel Go repo.

(With the use of submodules, I could actually show you a preview of open-telemetry/opentelemetry-go#2189 by referring to the PR branch, but I won't set that up now to avoid confusion.)

@chalin
Copy link
Contributor Author

chalin commented Aug 18, 2021

Oops, I forgot to cc the OTel Go maintainers in the opening comment, so I'm doing it here.
/cc @Aneurysm9 @MrAlias

@chalin chalin mentioned this pull request Aug 18, 2021
5 tasks
@chalin
Copy link
Contributor Author

chalin commented Aug 18, 2021

open-telemetry/opentelemetry-go#2189 has been reviewed and merged (thanks @Aneurysm9 @MrAlias!), so I refreshed the submodule in this PR.

You can now preview the Go page GH links: https://deploy-preview-690--opentelemetry.netlify.app/docs/go/

@chalin
Copy link
Contributor Author

chalin commented Aug 18, 2021

Thanks for the approval of this PR @MrAlias!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:CI/infra CI & infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants