Skip to content

Remove unused internal member, shows that Config.DefaultHistogramBoundaries is unused #2765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrAlias merged 2 commits into from
Apr 7, 2022
Merged

Remove unused internal member, shows that Config.DefaultHistogramBoundaries is unused #2765

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a9711c
Remove unused internal member, shows that Config.DefaultHistogramBoun…
bogdandrutu Apr 4, 2022
88cc385
Merge branch 'main' into rmdeadcode
hanyuancheung Apr 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions exporters/prometheus/prometheus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@ type Exporter struct {
// controllers (e.g., with different resources).
lock sync.RWMutex
controller *controller.Controller

defaultHistogramBoundaries []float64
}

// ErrUnsupportedAggregator is returned for unrepresentable aggregator
Expand Down Expand Up @@ -104,11 +102,10 @@ func New(config Config, controller *controller.Controller) (*Exporter, error) {
}

e := &Exporter{
handler: promhttp.HandlerFor(config.Gatherer, promhttp.HandlerOpts{}),
registerer: config.Registerer,
gatherer: config.Gatherer,
controller: controller,
defaultHistogramBoundaries: config.DefaultHistogramBoundaries,
handler: promhttp.HandlerFor(config.Gatherer, promhttp.HandlerOpts{}),
registerer: config.Registerer,
gatherer: config.Gatherer,
controller: controller,
}

c := &collector{
Expand Down