Skip to content

Remove unused internal member, shows that Config.DefaultHistogramBoundaries is unused - #2765

Merged
MrAlias merged 2 commits into
open-telemetry:mainfrom
bogdandrutu:rmdeadcode
Apr 7, 2022
Merged

Remove unused internal member, shows that Config.DefaultHistogramBoundaries is unused#2765
MrAlias merged 2 commits into
open-telemetry:mainfrom
bogdandrutu:rmdeadcode

Conversation

@bogdandrutu

Copy link
Copy Markdown
Member

Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com

…daries is unused

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>

@jmacd jmacd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov

codecov Bot commented Apr 7, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2765 (88cc385) into main (4bbf8d6) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2765   +/-   ##
=====================================
  Coverage   76.7%   76.8%           
=====================================
  Files        181     181           
  Lines      12189   12188    -1     
=====================================
+ Hits        9361    9366    +5     
+ Misses      2603    2597    -6     
  Partials     225     225           
Impacted Files Coverage Δ
exporters/prometheus/prometheus.go 65.0% <100.0%> (-0.3%) ⬇️
exporters/jaeger/jaeger.go 91.1% <0.0%> (+0.8%) ⬆️
sdk/trace/batch_span_processor.go 82.1% <0.0%> (+1.8%) ⬆️

@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 7, 2022
@MrAlias
MrAlias merged commit 376c23c into open-telemetry:main Apr 7, 2022
@bogdandrutu
bogdandrutu deleted the rmdeadcode branch April 11, 2022 16:10
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants