Skip to content

chore: remove deprecated SQSAttributeSetter functions from instrumentation/github.com/aws/aws-sdk-go-v2/otelaws - #7145

Merged
MrAlias merged 10 commits into
open-telemetry:mainfrom
PhilemonBrain:otelaws/SNSAttributeSetter
Apr 8, 2025
Merged

chore: remove deprecated SQSAttributeSetter functions from instrumentation/github.com/aws/aws-sdk-go-v2/otelaws#7145
MrAlias merged 10 commits into
open-telemetry:mainfrom
PhilemonBrain:otelaws/SNSAttributeSetter

Conversation

@PhilemonBrain

@PhilemonBrain PhilemonBrain commented Apr 3, 2025

Copy link
Copy Markdown
Contributor

Closes #7098

@PhilemonBrain
PhilemonBrain requested a review from a team as a code owner April 3, 2025 10:07
@github-actions
github-actions Bot requested a review from akats7 April 3, 2025 10:08
@PhilemonBrain

PhilemonBrain commented Apr 3, 2025

Copy link
Copy Markdown
Contributor Author

Closes: #7098

@codecov

codecov Bot commented Apr 3, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.9%. Comparing base (b3b0bce) to head (0b95cd2).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7145   +/-   ##
=====================================
  Coverage   75.9%   75.9%           
=====================================
  Files        206     206           
  Lines      19308   19306    -2     
=====================================
  Hits       14667   14667           
+ Misses      4210    4208    -2     
  Partials     431     431           
Files with missing lines Coverage Δ
...hub.com/aws/aws-sdk-go-v2/otelaws/sqsattributes.go 100.0% <ø> (+5.5%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrAlias

MrAlias commented Apr 6, 2025

Copy link
Copy Markdown
Contributor

@PhilemonBrain the linked issue is scoped to remove SQSAttributeSetter. This is removing `SNSAttributeSetter which has already been resolved by #7136.

@PhilemonBrain PhilemonBrain changed the title chore: remove SNSAttributeSetter from instrumentation/github.com/aws/aws-sdk-go-v2/otelaws chore: remove deprecated SQSAttributeSetter functions from instrumentation/github.com/aws/aws-sdk-go-v2/otelaws Apr 8, 2025
Comment thread CHANGELOG.md Outdated
Comment thread CHANGELOG.md Outdated
@PhilemonBrain

Copy link
Copy Markdown
Contributor Author

@MrAlias Thanks for your patience

@MrAlias

MrAlias commented Apr 8, 2025

Copy link
Copy Markdown
Contributor

Not a problem. Thanks for the contribution.

@MrAlias
MrAlias merged commit 46a2881 into open-telemetry:main Apr 8, 2025
@MrAlias MrAlias added this to the v1.36.0 milestone Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the deprecated SQSAttributeSetter function in otelaws

3 participants