Skip to content

Remove deprecated SNSAttributeSetter function in otelaws - #7136

Merged
MrAlias merged 5 commits into
open-telemetry:mainfrom
hostejulien:remove-sns-attribute-setter-func
Apr 5, 2025
Merged

Remove deprecated SNSAttributeSetter function in otelaws#7136
MrAlias merged 5 commits into
open-telemetry:mainfrom
hostejulien:remove-sns-attribute-setter-func

Conversation

@hostejulien

@hostejulien hostejulien commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

This pull request removes the deprecated SNSAttributeSetter function from the otelaws package.

Related Issue: Closes #7097

@hostejulien
hostejulien requested a review from a team as a code owner April 2, 2025 21:02
@linux-foundation-easycla

linux-foundation-easycla Bot commented Apr 2, 2025

Copy link
Copy Markdown

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions
github-actions Bot requested a review from akats7 April 2, 2025 21:02
@hostejulien hostejulien changed the title Remove deprecated SNSAttributeBuilder function in otelaws Remove deprecated SNSAttributeSetter function in otelaws Apr 2, 2025
Comment thread CHANGELOG.md Outdated
@codecov

codecov Bot commented Apr 2, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.8%. Comparing base (ae71e3e) to head (761b61a).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #7136     +/-   ##
=======================================
- Coverage   75.8%   75.8%   -0.1%     
=======================================
  Files        207     207             
  Lines      19393   19391      -2     
=======================================
- Hits       14717   14714      -3     
  Misses      4243    4243             
- Partials     433     434      +1     
Files with missing lines Coverage Δ
...hub.com/aws/aws-sdk-go-v2/otelaws/snsattributes.go 88.0% <ø> (+6.5%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrAlias MrAlias left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good outside of the changelog entry fixes mentioned by @pellared. Thanks for the contribution!

@hostejulien
hostejulien force-pushed the remove-sns-attribute-setter-func branch from 53238ae to 880e2c9 Compare April 4, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the deprecated SNSAttributeSetter function in otelaws

4 participants