exporter/prometheusremotewriterexporter: close HTTP response body #2875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a leak in HTTP responses after sending protobuf payloads to Amazon's endpoints. This change ensures that connections can be successfully reused, otherwise without invoking .Close() they won't easily be reused. Discovered while investigating for anything that could be averse to scalability of the exporter. Fixes open-telemetry#2874
bogdandrutu
approved these changes
Apr 1, 2021
Codecov Report
@@ Coverage Diff @@
## main #2875 +/- ##
=======================================
Coverage 91.77% 91.77%
=======================================
Files 286 286
Lines 15087 15088 +1
=======================================
+ Hits 13846 13847 +1
- Misses 848 849 +1
+ Partials 393 392 -1
Continue to review full report at Codecov.
|
pjanotti
pushed a commit
to pjanotti/opentelemetry-service
that referenced
this pull request
Apr 6, 2021
…en-telemetry#2875) Fixes a leak in HTTP responses after sending protobuf payloads to Amazon's endpoints. This change ensures that connections can be successfully reused, otherwise without invoking .Close() they won't easily be reused. Discovered while investigating for anything that could be averse to scalability of the exporter. Fixes open-telemetry#2874
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a leak in HTTP responses after sending protobuf payloads
to Amazon's endpoints. This change ensures that connections
can be successfully reused, otherwise without invoking .Close()
they won't easily be reused.
Discovered while investigating for anything that could be averse
to scalability of the exporter.
Fixes #2874
/cc @Aneurysm9 @rakyll @alolita