exporter/prometheusremotewriterexporter: close HTTP response body (open-telemetry#2875)

odeke-em · pjanotti · commit 85168e65e534 · 2021-04-06T12:20:55.000-07:00
Fixes a leak in HTTP responses after sending protobuf payloads to Amazon's endpoints. This change ensures that connections can be successfully reused, otherwise without invoking .Close() they won't easily be reused. Discovered while investigating for anything that could be averse to scalability of the exporter. Fixes open-telemetry#2874
diff --git a/exporter/prometheusremotewriteexporter/exporter.go b/exporter/prometheusremotewriteexporter/exporter.go
@@ -324,6 +324,7 @@ func (prwe *PrwExporter) execute(ctx context.Context, writeReq *prompb.WriteRequ
 	if err != nil {
 		return consumererror.Permanent(err)
 	}
+	defer resp.Body.Close()
 
 	// 2xx status code is considered a success
 	// 5xx errors are recoverable and the exporter should retry

Original file line number	Diff line number	Diff line change
`@@ -324,6 +324,7 @@ func (prwe PrwExporter) execute(ctx context.Context, writeReq prompb.WriteRequ`
`324`	`324`	`if err != nil {`
`325`	`325`	`return consumererror.Permanent(err)`
`326`	`326`	`}`
	`327`	`+ defer resp.Body.Close()`
`327`	`328`
`328`	`329`	`// 2xx status code is considered a success`
`329`	`330`	`// 5xx errors are recoverable and the exporter should retry`