Skip to content

Conversation

@naseemkullah
Copy link
Member

fixes #2643

@naseemkullah naseemkullah requested a review from a team March 11, 2021 11:45
@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #2668 (f68a94b) into main (e5175ed) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2668   +/-   ##
=======================================
  Coverage   91.77%   91.78%           
=======================================
  Files         291      291           
  Lines       15538    15552   +14     
=======================================
+ Hits        14260    14274   +14     
  Misses        877      877           
  Partials      401      401           
Impacted Files Coverage Δ
exporter/exporterhelper/logshelper.go 100.00% <100.00%> (ø)
exporter/exporterhelper/metricshelper.go 100.00% <100.00%> (ø)
exporter/exporterhelper/tracehelper.go 100.00% <100.00%> (ø)
exporter/prometheusexporter/prometheus.go 100.00% <100.00%> (ø)
obsreport/obsreport_exporter.go 95.00% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5175ed...f68a94b. Read the comment docs.

@bogdandrutu
Copy link
Member

this needs a rebase :)

@naseemkullah naseemkullah force-pushed the obsreport-exporter-cfg branch 4 times, most recently from ad4e82d to d60e24f Compare March 19, 2021 17:51
@naseemkullah naseemkullah force-pushed the obsreport-exporter-cfg branch from d60e24f to f68a94b Compare March 19, 2021 17:53
@naseemkullah
Copy link
Member Author

this needs a rebase :)

done!

@naseemkullah
Copy link
Member Author

bump

@bogdandrutu bogdandrutu merged commit 9c14430 into open-telemetry:main Mar 24, 2021
hughesjj added a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change NewExporterObsReport to accept Settings/Params instead of direct arguments

2 participants