configure obsReport.NewProcessor with struct (#2669)

* configure obsReport.NewProcessor with struct

fixes #2640

Signed-off-by: naseemkullah <[email protected]>

* s/ProcessorConfig/ProcessorSettings

Signed-off-by: naseemkullah <[email protected]>

Author: Naseem

obsreport/obsreport_processor.go

@@ -121,10 +121,15 @@ type Processor struct {
 	mutators []tag.Mutator
 }
 
-func NewProcessor(level configtelemetry.Level, processorName string) *Processor {
+type ProcessorSettings struct {
+	Level         configtelemetry.Level
+	ProcessorName string
+}
+
+func NewProcessor(cfg ProcessorSettings) *Processor {
 	return &Processor{
-		level:    level,
-		mutators: []tag.Mutator{tag.Upsert(tagKeyProcessor, processorName, tag.WithTTL(tag.TTLNoPropagation))},
+		level:    cfg.Level,
+		mutators: []tag.Mutator{tag.Upsert(tagKeyProcessor, cfg.ProcessorName, tag.WithTTL(tag.TTLNoPropagation))},
 	}
 }
 

obsreport/obsreport_test.go

@@ -547,7 +547,7 @@ func TestProcessorTraceData(t *testing.T) {
 	const refusedSpans = 19
 	const droppedSpans = 13
 
-	obsrep := obsreport.NewProcessor(configtelemetry.LevelNormal, processor)
+	obsrep := obsreport.NewProcessor(obsreport.ProcessorSettings{configtelemetry.LevelNormal, processor})
 	obsrep.TracesAccepted(context.Background(), acceptedSpans)
 	obsrep.TracesRefused(context.Background(), refusedSpans)
 	obsrep.TracesDropped(context.Background(), droppedSpans)
@@ -564,7 +564,7 @@ func TestProcessorMetricsData(t *testing.T) {
 	const refusedPoints = 11
 	const droppedPoints = 17
 
-	obsrep := obsreport.NewProcessor(configtelemetry.LevelNormal, processor)
+	obsrep := obsreport.NewProcessor(obsreport.ProcessorSettings{configtelemetry.LevelNormal, processor})
 	obsrep.MetricsAccepted(context.Background(), acceptedPoints)
 	obsrep.MetricsRefused(context.Background(), refusedPoints)
 	obsrep.MetricsDropped(context.Background(), droppedPoints)
@@ -635,7 +635,7 @@ func TestProcessorLogRecords(t *testing.T) {
 	const refusedRecords = 11
 	const droppedRecords = 17
 
-	obsrep := obsreport.NewProcessor(configtelemetry.LevelNormal, processor)
+	obsrep := obsreport.NewProcessor(obsreport.ProcessorSettings{configtelemetry.LevelNormal, processor})
 	obsrep.LogsAccepted(context.Background(), acceptedRecords)
 	obsrep.LogsRefused(context.Background(), refusedRecords)
 	obsrep.LogsDropped(context.Background(), droppedRecords)

processor/memorylimiter/memorylimiter.go

@@ -118,7 +118,10 @@ func newMemoryLimiter(logger *zap.Logger, cfg *Config) (*memoryLimiter, error) {
 		readMemStatsFn: runtime.ReadMemStats,
 		procName:       cfg.Name(),
 		logger:         logger,
-		obsrep:         obsreport.NewProcessor(configtelemetry.GetMetricsLevelFlagValue(), cfg.Name()),
+		obsrep: obsreport.NewProcessor(obsreport.ProcessorSettings{
+			Level:         configtelemetry.GetMetricsLevelFlagValue(),
+			ProcessorName: cfg.Name(),
+		}),
 	}
 
 	ml.startMonitoring()

processor/memorylimiter/memorylimiter_test.go

@@ -110,7 +110,11 @@ func TestMetricsMemoryPressureResponse(t *testing.T) {
 		readMemStatsFn: func(ms *runtime.MemStats) {
 			ms.Alloc = currentMemAlloc
 		},
-		obsrep: obsreport.NewProcessor(configtelemetry.LevelNone, ""),
+		obsrep: obsreport.NewProcessor(obsreport.ProcessorSettings{
+			Level:         configtelemetry.LevelNone,
+			ProcessorName: "",
+		}),
+
 		logger: zap.NewNop(),
 	}
 	mp, err := processorhelper.NewMetricsProcessor(
@@ -181,7 +185,10 @@ func TestTraceMemoryPressureResponse(t *testing.T) {
 		readMemStatsFn: func(ms *runtime.MemStats) {
 			ms.Alloc = currentMemAlloc
 		},
-		obsrep: obsreport.NewProcessor(configtelemetry.LevelNone, ""),
+		obsrep: obsreport.NewProcessor(obsreport.ProcessorSettings{
+			Level:         configtelemetry.LevelNone,
+			ProcessorName: "",
+		}),
 		logger: zap.NewNop(),
 	}
 	tp, err := processorhelper.NewTraceProcessor(
@@ -252,7 +259,10 @@ func TestLogMemoryPressureResponse(t *testing.T) {
 		readMemStatsFn: func(ms *runtime.MemStats) {
 			ms.Alloc = currentMemAlloc
 		},
-		obsrep: obsreport.NewProcessor(configtelemetry.LevelNone, ""),
+		obsrep: obsreport.NewProcessor(obsreport.ProcessorSettings{
+			Level:         configtelemetry.LevelNone,
+			ProcessorName: "",
+		}),
 		logger: zap.NewNop(),
 	}
 	lp, err := processorhelper.NewLogsProcessor(