Change SetFunction signature to return the function's ID, not update#14032
Merged
mx-psi merged 2 commits intoopen-telemetry:mainfrom Oct 22, 2025
Merged
Change SetFunction signature to return the function's ID, not update#14032mx-psi merged 2 commits intoopen-telemetry:mainfrom
mx-psi merged 2 commits intoopen-telemetry:mainfrom
Conversation
7 tasks
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (60.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #14032 +/- ##
==========================================
+ Coverage 91.67% 91.68% +0.01%
==========================================
Files 654 654
Lines 42619 42607 -12
==========================================
- Hits 39069 39065 -4
+ Misses 2738 2732 -6
+ Partials 812 810 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bogdandrutu
reviewed
Oct 15, 2025
Member
Author
|
None of those methods are currently used in contrib. So there shouldn't be any change needed there (as proof, contrib tests pass on all 3 PRs). |
Merged
via the queue into
open-telemetry:main
with commit Oct 22, 2025
848b7b6
69 of 80 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #14016