Skip to content

Change SetMapping signature to return the mapping's ID, not update#14030

Merged
mx-psi merged 3 commits intoopen-telemetry:mainfrom
dmathieu:set-mapping-immutable
Oct 22, 2025
Merged

Change SetMapping signature to return the mapping's ID, not update#14030
mx-psi merged 3 commits intoopen-telemetry:mainfrom
dmathieu:set-mapping-immutable

Conversation

@dmathieu
Copy link
Member

Part of #14016

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.62%. Comparing base (5174026) to head (74856fe).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pdata/pprofile/mappings.go 60.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (60.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14030      +/-   ##
==========================================
+ Coverage   91.61%   91.62%   +0.01%     
==========================================
  Files         655      655              
  Lines       42790    42778      -12     
==========================================
- Hits        39200    39196       -4     
+ Misses       2766     2760       -6     
+ Partials      824      822       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu dmathieu marked this pull request as ready for review October 15, 2025 12:09
@dmathieu dmathieu requested review from a team and mx-psi as code owners October 15, 2025 12:09
@dmathieu
Copy link
Member Author

Note that there is no contrib change required here, since this method isn't used there.

@mx-psi mx-psi added this pull request to the merge queue Oct 22, 2025
Merged via the queue into open-telemetry:main with commit 0e6e67d Oct 22, 2025
59 of 60 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 22, 2025
@dmathieu dmathieu deleted the set-mapping-immutable branch October 24, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants