Skip to content

Conversation

@songy23
Copy link
Member

@songy23 songy23 commented Jul 29, 2024

From https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/release.md#releasing-opentelemetry-collector:

If not intending to release stable modules, do not specify a version for Release candidate version stable.

validate-versions workflow fails on empty version right now, it should instead skip if stable module candidate version is empty.

@songy23 songy23 requested review from a team and bogdandrutu July 29, 2024 16:24
Copy link
Contributor

@jackgopack4 jackgopack4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally and this works. Ran into this issue recently testing changes to the build/release process for ocb, as well.

@codecov
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.17%. Comparing base (fb5b1e6) to head (f57778c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10734   +/-   ##
=======================================
  Coverage   92.17%   92.17%           
=======================================
  Files         401      401           
  Lines       18786    18786           
=======================================
  Hits        17316    17316           
  Misses       1110     1110           
  Partials      360      360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes me wonder if we need the same check for beta values as well... i can imagine we may want to release stable and beta separately in the future

@songy23
Copy link
Member Author

songy23 commented Jul 29, 2024

I filed a tracking issue to further fix this script as there are different scenarios to consider
#10735

@codeboten codeboten merged commit 6de4ce7 into open-telemetry:main Jul 29, 2024
@github-actions github-actions bot added this to the next release milestone Jul 29, 2024
@songy23 songy23 deleted the fix-validate-versions branch July 29, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants