Skip to content

Conversation

@atoulme
Copy link
Contributor

@atoulme atoulme commented Oct 31, 2025

Both functions are used for benchmarks in the module. They do not need to be exposed as API.

@atoulme atoulme force-pushed the unexport_functions branch from 350831f to fe24cb2 Compare October 31, 2025 16:25
Copy link
Member

@celian-garcia celian-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah dammit sorry, I always forget that. Isn't it part of the pipeline checks ?

@codeboten codeboten merged commit 9784adc into open-telemetry:main Oct 31, 2025
189 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 31, 2025
@codeboten
Copy link
Contributor

Ah dammit sorry, I always forget that. Isn't it part of the pipeline checks ?

@atoulme has been doing some work to enable a newer version of the check api (see #43134)

jelly-afk pushed a commit to jelly-afk/opentelemetry-collector-contrib that referenced this pull request Nov 6, 2025
Both functions are used for benchmarks in the module. They do not need
to be exposed as API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants