Skip to content

Commit 9784adc

Browse files
authored
[receiver/azuremonitor] unexport functions (#43937)
Both functions are used for benchmarks in the module. They do not need to be exposed as API.
1 parent f3f3230 commit 9784adc

File tree

3 files changed

+33
-6
lines changed

3 files changed

+33
-6
lines changed

.chloggen/unexport_functions.yaml

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: breaking
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. receiver/filelog)
7+
component: receiver/azuremonitor
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: unexport NewMutexMapImpl and NewSyncMapImpl
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [43925]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# If your change doesn't affect end users or the exported elements of any package,
21+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
22+
# Optional: The change log or logs in which this entry should be included.
23+
# e.g. '[user]' or '[user, api]'
24+
# Include 'user' if the change is relevant to end users.
25+
# Include 'api' if there is a change to a library API.
26+
# Default: '[user]'
27+
change_logs: [api]

receiver/azuremonitorreceiver/concurrency.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ type syncMapImpl[V any] struct {
4747
m sync.Map
4848
}
4949

50-
func NewSyncMapImpl[V any]() concurrentMetricsBuilderMap[V] {
50+
func newSyncMapImpl[V any]() concurrentMetricsBuilderMap[V] {
5151
return &syncMapImpl[V]{}
5252
}
5353

@@ -85,7 +85,7 @@ type mutexMapImpl[V any] struct {
8585
mutex sync.RWMutex
8686
}
8787

88-
func NewMutexMapImpl[V any]() concurrentMetricsBuilderMap[V] {
88+
func newMutexMapImpl[V any]() concurrentMetricsBuilderMap[V] {
8989
return &mutexMapImpl[V]{m: make(map[string]V)}
9090
}
9191

receiver/azuremonitorreceiver/concurrency_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,12 @@ func BenchmarkConcurrentMapImpl(b *testing.B) {
2525
}
2626

2727
func BenchmarkSyncMapImpl(b *testing.B) {
28-
m := NewSyncMapImpl[int]()
28+
m := newSyncMapImpl[int]()
2929
benchmarkMapImpl(b, m)
3030
}
3131

3232
func BenchmarkMutexMapImpl(b *testing.B) {
33-
m := NewMutexMapImpl[int]()
33+
m := newMutexMapImpl[int]()
3434
benchmarkMapImpl(b, m)
3535
}
3636

@@ -63,11 +63,11 @@ func BenchmarkConcurrentMapImplLarge(b *testing.B) {
6363
}
6464

6565
func BenchmarkSyncMapImplLarge(b *testing.B) {
66-
m := NewSyncMapImpl[int]()
66+
m := newSyncMapImpl[int]()
6767
benchmarkMapImplLarge(b, m)
6868
}
6969

7070
func BenchmarkMutexMapImplLarge(b *testing.B) {
71-
m := NewMutexMapImpl[int]()
71+
m := newMutexMapImpl[int]()
7272
benchmarkMapImplLarge(b, m)
7373
}

0 commit comments

Comments
 (0)