[cmd/opampsupervisor] Fix supervisor ignoring RemoteConfig messages #42497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaasman00
requested review from
a team,
atoulme and
evan-bradley
as code owners
Co-authored-by: Evan Bradley <[email protected]>
atoulme
approved these changes
Sep 6, 2025
dpaasman00
added a commit
to observIQ/opentelemetry-collector-contrib
that referenced
this pull request
Sep 10, 2025
…pen-telemetry#42497) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> The supervisor will sometimes ignore certain Remote Config messages from the server. Specifically if the supervisor does not think the config is different. Instead it should still respond. In the event the supervisor does not think the config is different, it will send an applied status (functionally the config that was sent is being ran, so applied is appropriate here). <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> Fixes open-telemetry#42474 <!--Describe what testing was performed and which tests were added.--> Unit tests updated <!--Describe the documentation added.--> <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Evan Bradley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The supervisor will sometimes ignore certain Remote Config messages from the server. Specifically if the supervisor does not think the config is different. Instead it should still respond. In the event the supervisor does not think the config is different, it will send an applied status (functionally the config that was sent is being ran, so applied is appropriate here).
Link to tracking issue
Fixes #42474
Testing
Unit tests updated
Documentation