-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Description
Component(s)
cmd/opampsupervisor
What happened?
Description
When the supervisor receives a remote config from the OpAMP server, it only sends a response to the server if the supervisor runs into an error evaluating the config or if it decides to apply the configuration to the collector.
Steps to Reproduce
There's no standard for an OpAMP server, so I'll just describe the situation where this can happen.
Start the supervisor and collector and send a remote configuration to the supervisor. The supervisor should successfully accept the remote config, apply the remote config to the collector, and report an applied status. Now the server should send a new remote config to the server. The new config should have a different hash than the one sent before, but the supervisor should evaluate as functionally equivalent to the previous config. An easy way to do this is change the order in which components are defined.
Expected Result
Ideally the supervisor should report some updated status about the remote configuration the server has sent it. The way the supervisor evaluates the configuration may mean there's not functional difference between the last remote config and this new one, but the config hash has changed and the server will likely expect a response.
Actual Result
The supervisor ignores the remote config message and doesn't respond with a status related to the config it was sent. This can be problematic as the server should expect a response of some kind about the configuration it has sent.
Supervisor version
main
Environment information
Environment
This can be seen across environments.
Additional context
This topic was discussed in today's OpAMP SIG meeting and we agreed the server may expect a response from the agent after sending a remote configuration.
I'll have a PR up addressing this bug shortly.
Tip
React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it. Learn more here.