implement max size feature on file storage extension #42024
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsains
force-pushed
the
filestorage-max
branch
from
a2aae3d to
2cc5d8f
Compare
Contributor
Author
|
I see the unit tests failed, I am not getting this error locally so will need to take some time to figure out what's going on here |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Contributor
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change allows the file storage extension to be configured with a maximum limit. The DB file will not exceed this limit when written to. If a write would cause the file to grow beyond this size, a new standard error (see open-telemetry/opentelemetry-collector#12925) will be returned.
Link to tracking issue
Fixes #38620
Testing
Unit tests were added to test this functionality.