[chore] Fix addlicense and checklicense Makefile targets #38493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmocosta
changed the title
Contributor
Author
|
Red CI means it worked, which is an unusual thing to say! 
I'll run |
github-actions
bot
added
cmd/telemetrygen
edmocosta
force-pushed
the
fix-makefile-license-targets
branch
from
f14ccec to
fb4409b
Compare
Contributor
Contributor
Author
|
I'm not a Make expert, but this approach is slightly different from the previous one. The find command should only be executed when it expands the variable value (usages), so it shouldn't slow down other targets. Another option would be setting it at target level, but I think that would require using |
dehaansa
approved these changes
Mar 10, 2025
atoulme
pushed a commit
that referenced
this pull request
Mar 19, 2025
Re-enable the use of `make` for the `hostmetricsreceiver` by fixing the target that was being suppressed. For targets `misspell` and `misspell-correction` there is no need anymore of a different version for Windows. For targets `addlicense` and `checklicense` we can't have a computed variable with all the filenames since this becomes too big for `/bin/bash`. I changed it back to the same pattern used in #37951. I tested on Windows and Mac and the issue described at #38493 didn't repro with this current change.
lightme16
pushed a commit
to lightme16/opentelemetry-collector-contrib
that referenced
this pull request
Mar 19, 2025
…try#38773) Re-enable the use of `make` for the `hostmetricsreceiver` by fixing the target that was being suppressed. For targets `misspell` and `misspell-correction` there is no need anymore of a different version for Windows. For targets `addlicense` and `checklicense` we can't have a computed variable with all the filenames since this becomes too big for `/bin/bash`. I changed it back to the same pattern used in open-telemetry#37951. I tested on Windows and Mac and the issue described at open-telemetry#38493 didn't repro with this current change.
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…try#38773) Re-enable the use of `make` for the `hostmetricsreceiver` by fixing the target that was being suppressed. For targets `misspell` and `misspell-correction` there is no need anymore of a different version for Windows. For targets `addlicense` and `checklicense` we can't have a computed variable with all the filenames since this becomes too big for `/bin/bash`. I changed it back to the same pattern used in open-telemetry#37951. I tested on Windows and Mac and the issue described at open-telemetry#38493 didn't repro with this current change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the checklicense target as it's using spaces instead of tabs, leading the checklicense target to skip the header's verifications as the variable is not properly working. The
addlicensetarget is also printing the following errors, which is probably being caused by syntax currently used to try to set target-scoped variables: