[chore] move evaluation of file lists to tasks to reduce Makefile setup #37951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
makefile_fixes
branch
from
cfb1ed1 to
2c595a2
Compare
Contributor
Author
|
I have split the typo fixes in this PR to a separate PR #37952. |
dehaansa
approved these changes
Feb 17, 2025
djaglowski
approved these changes
Feb 17, 2025
MovieStoreGuy
approved these changes
Feb 19, 2025
atoulme
pushed a commit
that referenced
this pull request
Mar 19, 2025
Re-enable the use of `make` for the `hostmetricsreceiver` by fixing the target that was being suppressed. For targets `misspell` and `misspell-correction` there is no need anymore of a different version for Windows. For targets `addlicense` and `checklicense` we can't have a computed variable with all the filenames since this becomes too big for `/bin/bash`. I changed it back to the same pattern used in #37951. I tested on Windows and Mac and the issue described at #38493 didn't repro with this current change.
lightme16
pushed a commit
to lightme16/opentelemetry-collector-contrib
that referenced
this pull request
Mar 19, 2025
…try#38773) Re-enable the use of `make` for the `hostmetricsreceiver` by fixing the target that was being suppressed. For targets `misspell` and `misspell-correction` there is no need anymore of a different version for Windows. For targets `addlicense` and `checklicense` we can't have a computed variable with all the filenames since this becomes too big for `/bin/bash`. I changed it back to the same pattern used in open-telemetry#37951. I tested on Windows and Mac and the issue described at open-telemetry#38493 didn't repro with this current change.
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…try#38773) Re-enable the use of `make` for the `hostmetricsreceiver` by fixing the target that was being suppressed. For targets `misspell` and `misspell-correction` there is no need anymore of a different version for Windows. For targets `addlicense` and `checklicense` we can't have a computed variable with all the filenames since this becomes too big for `/bin/bash`. I changed it back to the same pattern used in open-telemetry#37951. I tested on Windows and Mac and the issue described at open-telemetry#38493 didn't repro with this current change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is brought about by the realization that with #37945 no code is directly under the root module. This has the unexpected impact that some of the Makefile set up started to show warnings.
It turns out that we do quite a bit of reading files and go packages in the Makefile. This has a performance impact. We also have incorrect code in there, such as the computation of
ALL_PKG_DIRSonly returnsgithub.zerozr99.workers.dev/open-telemetry/opentelemetry-collector-contrib/cmd/checkapi.