[bug_fix] [exporter/pulsar] Change configuration option #36579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
reviewed
Dec 2, 2024
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
This looks like a bugfix, can you please add a changelog to note the change in config option
liubingyan127
changed the title
Contributor
Author
Of course, I've added changelog. |
dmitryax
approved these changes
Dec 3, 2024
dao-jun
approved these changes
Dec 3, 2024
shivanthzen
pushed a commit
to shivanthzen/opentelemetry-collector-contrib
that referenced
this pull request
Dec 5, 2024
…ry#36579) #### Description I updated the name of the item `map_connections_per_broker` in the config and description in readme. Changed from `map_connections_per_broker` to `max_connections_per_broker`. From the description of the item in readme, I think this should be a typo. --------- Co-authored-by: Alex Boten <[email protected]>
ZenoCC-Peng
pushed a commit
to ZenoCC-Peng/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2024
…ry#36579) #### Description I updated the name of the item `map_connections_per_broker` in the config and description in readme. Changed from `map_connections_per_broker` to `max_connections_per_broker`. From the description of the item in readme, I think this should be a typo. --------- Co-authored-by: Alex Boten <[email protected]>
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…ry#36579) #### Description I updated the name of the item `map_connections_per_broker` in the config and description in readme. Changed from `map_connections_per_broker` to `max_connections_per_broker`. From the description of the item in readme, I think this should be a typo. --------- Co-authored-by: Alex Boten <[email protected]>
AkhigbeEromo
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Jan 13, 2025
…ry#36579) #### Description I updated the name of the item `map_connections_per_broker` in the config and description in readme. Changed from `map_connections_per_broker` to `max_connections_per_broker`. From the description of the item in readme, I think this should be a typo. --------- Co-authored-by: Alex Boten <[email protected]>
chengchuanpeng
pushed a commit
to chengchuanpeng/opentelemetry-collector-contrib
that referenced
this pull request
Jan 26, 2025
…ry#36579) #### Description I updated the name of the item `map_connections_per_broker` in the config and description in readme. Changed from `map_connections_per_broker` to `max_connections_per_broker`. From the description of the item in readme, I think this should be a typo. --------- Co-authored-by: Alex Boten <[email protected]>
zeck-ops
pushed a commit
to zeck-ops/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
…ry#36579) #### Description I updated the name of the item `map_connections_per_broker` in the config and description in readme. Changed from `map_connections_per_broker` to `max_connections_per_broker`. From the description of the item in readme, I think this should be a typo. --------- Co-authored-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I updated the name of the item
map_connections_per_brokerin the config and description in readme. Changed frommap_connections_per_brokertomax_connections_per_broker. From the description of the item in readme, I think this should be a typo.