Skip to content

Commit edc8857

Browse files
liubingyan127codeboten
authored andcommitted
[bug_fix] [exporter/pulsar] Change configuration option (open-telemetry#36579)
#### Description I updated the name of the item `map_connections_per_broker` in the config and description in readme. Changed from `map_connections_per_broker` to `max_connections_per_broker`. From the description of the item in readme, I think this should be a typo. --------- Co-authored-by: Alex Boten <[email protected]>
1 parent 72aeae9 commit edc8857

File tree

3 files changed

+29
-2
lines changed

3 files changed

+29
-2
lines changed
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: bug_fix
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
7+
component: exporter/pulsarexporter
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: Change configuration option `map_connections_per_broker`, rename to `max_connections_per_broker`.
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [36579]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# If your change doesn't affect end users or the exported elements of any package,
21+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
22+
# Optional: The change log or logs in which this entry should be included.
23+
# e.g. '[user]' or '[user, api]'
24+
# Include 'user' if the change is relevant to end users.
25+
# Include 'api' if there is a change to a library API.
26+
# Default: '[user]'
27+
change_logs: [user]

exporter/pulsarexporter/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ The following settings can be optionally configured:
6363
- `timeout`: send pulsar message timeout (default: 5s)
6464
- `operation_timeout`: sets producer-create, subscribe and unsubscribe operations timeout (default: 30 seconds)
6565
- `connection_timeout`: timeout for the establishment of a TCP connection (default: 5 seconds)
66-
- `map_connections_per_broker`: max number of connections to a single broker that will kept in the pool. (default: 1 connection)
66+
- `max_connections_per_broker`: max number of connections to a single broker that will kept in the pool. (default: 1 connection)
6767
- `retry_on_failure`
6868
- `enabled` (default = true)
6969
- `initial_interval` (default = 5s): Time to wait after the first failure before retrying; ignored if `enabled` is `false`

exporter/pulsarexporter/config.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ type Config struct {
3535
Authentication Authentication `mapstructure:"auth"`
3636
OperationTimeout time.Duration `mapstructure:"operation_timeout"`
3737
ConnectionTimeout time.Duration `mapstructure:"connection_timeout"`
38-
MaxConnectionsPerBroker int `mapstructure:"map_connections_per_broker"`
38+
MaxConnectionsPerBroker int `mapstructure:"max_connections_per_broker"`
3939
}
4040

4141
type Authentication struct {

0 commit comments

Comments
 (0)