Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 21, 2025

  • Add comprehensive unit tests for EntityLink grammar with reserved keywords
    • Add tests in TypeScript/JavaScript (EntityLink.test.ts) for reserved keywords as column names
    • Add tests in Python (test_entity_link.py) for reserved keywords as column names
    • Verify tests cover ENTITY_TYPE keywords (table, topic, database, role, chart, user, etc.)
    • Verify tests cover ENTITY_FIELD keywords (description, owner, tags, name, tests, etc.)
    • Verify tests cover reserved keywords with field access
    • Fixed Python formatting (removed trailing whitespace in docstrings)
  • Add Playwright E2E tests for EntityLink usage
    • Created custom table class with reserved keyword column names
    • Created comprehensive E2E test suite (EntityLinkReservedKeywords.spec.ts)
    • Test table column display with reserved keyword column names
    • Test adding descriptions to columns with reserved keywords
    • Test adding tags to columns with reserved keywords
    • Test task/annotation creation for reserved keyword columns
    • Test search and filter functionality for reserved keyword columns
    • Fixed function imports and calls based on code review feedback
    • Improved code quality based on review suggestions
  • Verify all tests pass
    • Run JavaScript/TypeScript unit tests (33 tests passed)
    • Python unit tests added (syntax validated, formatting fixed)
    • Run Playwright E2E tests (requires full environment setup)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copy link
Contributor Author

Copilot AI commented Nov 21, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • api.launchpad.net
    • Triggering command: /usr/bin/add-apt-repository add-apt-repository -y ppa:deadsnakes/ppa (dns block)
  • esm.ubuntu.com
    • Triggering command: /usr/lib/apt/methods/https /usr/lib/apt/methods/https (dns block)
  • www.antlr.org
    • Triggering command: /usr/bin/curl curl REDACTED (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Fix naming consistency for entity link parsing methods and grammar Add comprehensive tests for EntityLink grammar with reserved keywords Nov 21, 2025
Copilot AI requested a review from ayush-shah November 21, 2025 09:00
Copilot finished work on behalf of ayush-shah November 21, 2025 09:00
@ayush-shah ayush-shah marked this pull request as ready for review November 21, 2025 10:12
@ayush-shah ayush-shah requested review from a team as code owners November 21, 2025 10:12
@ayush-shah ayush-shah added the safe to test Add this label to run secure Github workflows on PRs label Nov 21, 2025
@github-actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@github-actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.43% (49461/77981) 40.5% (23646/58383) 44.29% (7494/16921)

@ayush-shah
Copy link
Member

@copilot

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Contributor Author

Copilot AI commented Nov 21, 2025

@copilot

The Python checkstyle failed.
...

Python formatting fixed. Ran black to fix trailing whitespace in docstrings.

Commit: bdc18ff

Copilot finished work on behalf of ayush-shah November 21, 2025 11:08
@ayush-shah ayush-shah merged commit 05d1c99 into refactor-entitylink Nov 21, 2025
19 of 26 checks passed
@ayush-shah ayush-shah deleted the copilot/sub-pr-24388 branch November 21, 2025 11:49
@sonarqubecloud
Copy link

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants