You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request updates the entity link parsing logic to better handle cases where reserved keywords (such as entity types and fields) are used as column names in entity links. The changes ensure that the parser and listeners correctly recognize and split entity links containing these keywords, and adds tests to verify this behavior.
Parser and grammar updates:
Updated the EntityLink.g4 grammar to allow nameOrFqn to match NAME_OR_FQN, ENTITY_TYPE, or ENTITY_FIELD, ensuring that reserved keywords can be parsed as column names.
Listener and parser implementation changes:
Renamed methods from enterNameOrFQN to enterNameOrFqn in both the Python (split_listener.py) and JavaScript (EntityLinkSplitListener.js) entity link split listeners to match the grammar update and ensure correct parsing behavior. [1][2]
Testing improvements:
Added unit tests to test_entity_link.py that verify entity links with reserved keywords (ENTITY_TYPE and ENTITY_FIELD) as column names are correctly split by the parser.
Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.
You can install the pre-commit hooks with make install_test precommit_install.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github-actions
bot
added
Ingestion
safe to test
This pull request updates the entity link parsing logic to better handle cases where reserved keywords (such as entity types and fields) are used as column names in entity links. The changes ensure that the parser and listeners correctly recognize and split entity links containing these keywords, and adds tests to verify this behavior.
Parser and grammar updates:
EntityLink.g4grammar to allownameOrFqnto matchNAME_OR_FQN,ENTITY_TYPE, orENTITY_FIELD, ensuring that reserved keywords can be parsed as column names.Listener and parser implementation changes:
enterNameOrFQNtoenterNameOrFqnin both the Python (split_listener.py) and JavaScript (EntityLinkSplitListener.js) entity link split listeners to match the grammar update and ensure correct parsing behavior. [1] [2]Testing improvements:
test_entity_link.pythat verify entity links with reserved keywords (ENTITY_TYPE and ENTITY_FIELD) as column names are correctly split by the parser.