Skip to content

chore: disable codspeed in op-reth #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2025
Merged

chore: disable codspeed in op-reth #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/bench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ jobs:
run: ./.github/scripts/codspeed-build.sh
- name: Run the benchmarks
uses: CodSpeedHQ/action@v4
env:
CODSPEED_TOKEN: ${{ secrets.CODSPEED_TOKEN }}
# op-reth does not have a codspeed token
if: ${{ env.CODSPEED_TOKEN != '' }}
Copy link

Copilot AI Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition should check for null/undefined values in addition to empty strings. Use if: ${{ secrets.CODSPEED_TOKEN != '' }} instead to directly reference the secret, or use if: ${{ env.CODSPEED_TOKEN }} which evaluates to false for null, undefined, or empty values.

Suggested change
if: ${{ env.CODSPEED_TOKEN != '' }}
if: ${{ secrets.CODSPEED_TOKEN != '' }}

Copilot uses AI. Check for mistakes.
with:
run: cargo codspeed run --workspace
mode: instrumentation
Expand Down
Loading