chore: disable codspeed in op-reth #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyer9
force-pushed
the
meyer9/disable-codspeed
branch
from
6055746 to
2c45b63
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR disables CodSpeed benchmark uploads when the CODSPEED_TOKEN secret is not available, preventing workflow failures in the op-reth repository.
- Adds conditional execution to the CodSpeed action based on token availability
- Includes environment variable setup for the CODSPEED_TOKEN
- Adds explanatory comment about op-reth lacking a CodSpeed token
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| env: | ||
| CODSPEED_TOKEN: ${{ secrets.CODSPEED_TOKEN }} | ||
| # op-reth does not have a codspeed token | ||
| if: ${{ env.CODSPEED_TOKEN != '' }} |
There was a problem hiding this comment.
The condition should check for null/undefined values in addition to empty strings. Use if: ${{ secrets.CODSPEED_TOKEN != '' }} instead to directly reference the secret, or use if: ${{ env.CODSPEED_TOKEN }} which evaluates to false for null, undefined, or empty values.
Suggested change
| if: ${{ env.CODSPEED_TOKEN != '' }} | |
| if: ${{ secrets.CODSPEED_TOKEN != '' }} |
dhyaniarun1993
approved these changes
Oct 14, 2025
emhane
pushed a commit
that referenced
this pull request
Oct 20, 2025
No token, so this check always fails annoyingly. Disabling the upload step if missing token.
meyer9
added a commit
that referenced
this pull request
Oct 31, 2025
No token, so this check always fails annoyingly. Disabling the upload step if missing token.
emhane
pushed a commit
that referenced
this pull request
Nov 11, 2025
No token, so this check always fails annoyingly. Disabling the upload step if missing token.
meyer9
added a commit
that referenced
this pull request
Nov 13, 2025
No token, so this check always fails annoyingly. Disabling the upload step if missing token.
emhane
pushed a commit
that referenced
this pull request
Nov 18, 2025
No token, so this check always fails annoyingly. Disabling the upload step if missing token.
emhane
pushed a commit
that referenced
this pull request
Nov 25, 2025
No token, so this check always fails annoyingly. Disabling the upload step if missing token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No token, so this check always fails annoyingly. Disabling the upload step if missing token.