Skip to content

fix: Show different messages and perform different actions depending on auth errors #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2020
Merged

fix: Show different messages and perform different actions depending on auth errors #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions src/app/http-interceptors/permission-interceptor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,10 @@ export class PermissionInterceptor implements HttpInterceptor {
const currentUrl = req.url;
const isOnPermittedUrl = pageUrl === '/login' || currentUrl === '/login' || currentUrl.indexOf('/apis/v1beta1/auth') > -1;

const errorStatus = error.status === 401 || error.status === 403;
// Display a login alert on a permissions related (401/403) error.
// Display a login alerts on a permissions related (401/403) error.
// If we're already displaying such an alert, don't display it again.
if(errorStatus && !this.snackbarRef && !isOnPermittedUrl) {
let message = 'Not logged in';
if(error.status === 403) {
message = 'Unauthorized'
}

if(error.status === 401 && !this.snackbarRef && !isOnPermittedUrl) {
let message = 'You are not logged in';
this.snackbarRef = this.snackbar.open(message, 'Login');
this.snackbarRef.afterDismissed()
.subscribe(res => {
Expand All @@ -47,6 +42,14 @@ export class PermissionInterceptor implements HttpInterceptor {
}
})
}
if(error.status === 403 && !this.snackbarRef && !isOnPermittedUrl) {
let message = 'Unauthorized';
this.snackbarRef = this.snackbar.open(message, 'Close');
this.snackbarRef.afterDismissed()
.subscribe(() => {
this.snackbarRef = null;
})
}

return throwError(error);
})
Expand Down