Skip to content

fix: Show different messages and perform different actions depending on auth errors #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2020
Merged

fix: Show different messages and perform different actions depending on auth errors #130

merged 1 commit into from
Jun 20, 2020

Conversation

@rushtehrani
Copy link
Contributor

@rushtehrani rushtehrani commented Jun 19, 2020

What this PR does:
Show different messages and actions depending on auth errors:

  • On 401, displays "You are not logged in" with a "Login" button that takes user to login page
  • On 403, displays "Unauthorized" with a "Close" button.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@rushtehrani rushtehrani requested a review from Vafilor June 19, 2020 21:55
@rushtehrani rushtehrani merged commit c6b6e7f into dev Jun 20, 2020
@rushtehrani rushtehrani deleted the fix/auth-snackbars branch June 20, 2020 00:51
@rushtehrani rushtehrani added this to the v0.11.0 milestone Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Vafilor Vafilor Awaiting requested review from Vafilor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.11.0

Development

Successfully merging this pull request may close these issues.

2 participants

@rushtehrani