Skip to content

feat: loading indicator when updating an edited workflow template #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2020
Merged

feat: loading indicator when updating an edited workflow template #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/app/workflow-template/workflow-template-edit/workflow-template-edit.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,10 @@
</div>
<div class="mt-5 d-flex justify-content-between">
<button mat-button class="font-medium-gray cancel-button" (click)="cancel()">CANCEL</button>
<div>
<button mat-flat-button color="accent" class="op-rounded op-button border-secondary" (click)="update()">Save</button>
</div>
<app-button [loading]="saving" (click)="update()">
Save
<span class="loading">Saving</span>
</app-button>
</div>
</div>
</div>
Expand Down
10 changes: 10 additions & 0 deletions src/app/workflow-template/workflow-template-edit/workflow-template-edit.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,11 @@ export class WorkflowTemplateEditComponent implements OnInit, CanComponentDeacti
*/
manifestChanged = false;

/**
* saving is true if the editor is currently saving the data and false otherwise.
*/
saving = false;

get workflowTemplate(): WorkflowTemplate {
return this._workflowTemplate;
}
Expand Down Expand Up @@ -148,6 +153,8 @@ export class WorkflowTemplateEditComponent implements OnInit, CanComponentDeacti

const manifestText = this.manifestDagEditor.manifestTextCurrent;

this.saving = true;

this.workflowTemplateService
.createWorkflowTemplateVersion(
this.namespace,
Expand All @@ -159,11 +166,14 @@ export class WorkflowTemplateEditComponent implements OnInit, CanComponentDeacti
})
.subscribe(res => {
this.appRouter.navigateToWorkflowTemplateView(this.namespace, this.workflowTemplate.uid);
this.saving = false;
}, (err: HttpErrorResponse) => {
this.manifestDagEditor.error = {
message: err.error.message,
type: 'danger',
};

this.saving = false;
});
}

Expand Down