Skip to content

Conversation

@Vafilor
Copy link
Contributor

@Vafilor Vafilor commented Jun 3, 2020

What type of PR is this?

/kind enhancement

What this PR does:

Add a loading indicator to the saving button in Workflow Template Edit page when it is saving.
This helps the user know something is happening and prevents multiple clicks.

Which issue(s) this PR fixes:

Fixes onepanelio/onepanel#320

Special notes for your reviewer:

None.

@Vafilor Vafilor added the kind/enhancement New feature or request label Jun 3, 2020
@Vafilor Vafilor added this to the v0.10.0 milestone Jun 3, 2020
@rushtehrani rushtehrani changed the title feature: loading indicator when updating an edited workflow template feat: loading indicator when updating an edited workflow template Jun 3, 2020
@rushtehrani rushtehrani merged commit 20af2c4 into dev Jun 4, 2020
@rushtehrani rushtehrani deleted the feature/onepanelio.core-320.loading.indicator.edit.workflow.template branch June 4, 2020 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants