Skip to content

chore: fix ci #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Groupguanfang merged 1 commit into from
Jan 21, 2026
Merged

chore: fix ci #255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/publish.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ function publishToVsce(): boolean {
try {
const packagePath = getExtensionPackagePath(target)
logger.info(`Publishing to VSCE for target ${target}...`)
const command = `pnpm -F vscode-naily-ets vsce publish --target ${target} --packagePath ${packagePath}`
const command = `pnpm -F vscode-naily-ets vsce publish --packagePath ${packagePath}`
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of --target ${target} from the vsce publish command creates an inconsistency with the publishToOvsce() function on line 72, which still includes --target ${target}. Both functions iterate over the same EXTENSION_TARGETS and use target-specific packages. If the target flag is redundant or causing issues for vsce, consider whether the same applies to ovsx, or document why they differ.

Copilot uses AI. Check for mistakes.
logger.info(`Executing command: ${command}`)
execSync(command, { cwd: path.resolve(dirname, '..'), stdio: 'inherit' })
}
Expand Down
Loading