Skip to content

chore: fix ci#255

Merged
Groupguanfang merged 1 commit intonextfrom
next-dev
Jan 21, 2026
Merged

chore: fix ci#255
Groupguanfang merged 1 commit intonextfrom
next-dev

Conversation

@Groupguanfang
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings January 21, 2026 02:06
@github-project-automation github-project-automation bot moved this to Todo in ArkTS Jan 21, 2026
@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2026

⚠️ No Changeset found

Latest commit: cbd9bc6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Groupguanfang Groupguanfang merged commit 8c564b5 into next Jan 21, 2026
5 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in ArkTS Jan 21, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a CI issue by removing the --target flag from the vsce publish command in the publish script. The change suggests that the target flag was causing problems during the publishing process, likely because target-specific packages are already being built and selected based on the target platform.

Changes:

  • Removed --target ${target} parameter from the vsce publish command while keeping the --packagePath parameter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

const packagePath = getExtensionPackagePath(target)
logger.info(`Publishing to VSCE for target ${target}...`)
const command = `pnpm -F vscode-naily-ets vsce publish --target ${target} --packagePath ${packagePath}`
const command = `pnpm -F vscode-naily-ets vsce publish --packagePath ${packagePath}`
Copy link

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of --target ${target} from the vsce publish command creates an inconsistency with the publishToOvsce() function on line 72, which still includes --target ${target}. Both functions iterate over the same EXTENSION_TARGETS and use target-specific packages. If the target flag is redundant or causing issues for vsce, consider whether the same applies to ovsx, or document why they differ.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant