Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a CI issue by removing the --target flag from the vsce publish command in the publish script. The change suggests that the target flag was causing problems during the publishing process, likely because target-specific packages are already being built and selected based on the target platform.
Changes:
- Removed
--target ${target}parameter from the vsce publish command while keeping the--packagePathparameter
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const packagePath = getExtensionPackagePath(target) | ||
| logger.info(`Publishing to VSCE for target ${target}...`) | ||
| const command = `pnpm -F vscode-naily-ets vsce publish --target ${target} --packagePath ${packagePath}` | ||
| const command = `pnpm -F vscode-naily-ets vsce publish --packagePath ${packagePath}` |
There was a problem hiding this comment.
The removal of --target ${target} from the vsce publish command creates an inconsistency with the publishToOvsce() function on line 72, which still includes --target ${target}. Both functions iterate over the same EXTENSION_TARGETS and use target-specific packages. If the target flag is redundant or causing issues for vsce, consider whether the same applies to ovsx, or document why they differ.
No description provided.