Skip to content

fix: Addresses URI parsing compatibility with Ruby 3.4 #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickfloyd merged 1 commit into from
Jul 24, 2024
Merged

fix: Addresses URI parsing compatibility with Ruby 3.4 #1708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/octokit/repository.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,14 @@ def url

private

ABS_URI_REGEXP = if URI.const_defined?(:RFC2396_PARSER) # Ruby 3.4+
URI::RFC2396_PARSER.regexp.fetch(:ABS_URI)
else
URI::RFC2396_Parser.new.regexp.fetch(:ABS_URI)
end

def validate_owner_and_name!(repo)
if @owner.include?('/') || @name.include?('/') || !url.match(URI::ABS_URI)
if @owner.include?('/') || @name.include?('/') || !url.match?(ABS_URI_REGEXP)
raise_invalid_repository!(repo)
end
end
Expand Down