fix: Addresses URI parsing compatibility with Ruby 3.4#1708
fix: Addresses URI parsing compatibility with Ruby 3.4#1708nickfloyd merged 1 commit intooctokit:mainfrom
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
But also older Rubies if the default URI parser is set to `RFC3986`.
9d8ab38 to
a4bae88
Compare
|
Hey @casperisfine, this change set looks good. Thanks for doing it! ❤️ Would you mind adding some tests? If not I can do that later. I'll approve either way and thanks again! Something like: |
|
It's already covered by tests in The issue is that the The test will only fail once these changes are released and updated in the Gemfile: ruby/uri#107 |
But also older Rubies if the default URI parser is set to
RFC3986.