Skip to content

fix: Allow zip MIME type #2902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickfloyd merged 1 commit into from
Apr 10, 2024
Merged

fix: Allow zip MIME type #2902

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Octokit/Http/HttpClientAdapter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ protected virtual async Task<IResponse> BuildResponse(HttpResponseMessage respon
AcceptHeaders.RawContentMediaType,
"application/zip" ,
"application/x-gzip" ,
"zip" , // Not a standard MIME type but see issue #2898
Copy link
Contributor

@nickfloyd nickfloyd Apr 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I am not super excited about not using the proper representation (asper the mdm web docs and iana) - I get the situation here. Thank you for making sure this is commented with context. ❤️

"application/octet-stream"};

var content = responseMessage.Content;
Expand Down