Skip to content

fix: Allow zip MIME type#2902

Merged
nickfloyd merged 1 commit intooctokit:mainfrom
thomhurst:feature/fix-zip-mime-type
Apr 10, 2024
Merged

fix: Allow zip MIME type#2902
nickfloyd merged 1 commit intooctokit:mainfrom
thomhurst:feature/fix-zip-mime-type

Conversation

@thomhurst
Copy link
Contributor

Fixes #2898

Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this change @thomhurst

AcceptHeaders.RawContentMediaType,
"application/zip" ,
"application/x-gzip" ,
"zip" , // Not a standard MIME type but see issue #2898
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I am not super excited about not using the proper representation (asper the mdm web docs and iana) - I get the situation here. Thank you for making sure this is commented with context. ❤️

@nickfloyd nickfloyd added Status: Wont fix This will not be worked on Type: Bug Something isn't working as documented Type: Feature New feature or request labels Apr 10, 2024
@nickfloyd nickfloyd changed the title Allow zip MIME type fix: Allow zip MIME type Apr 10, 2024
@nickfloyd nickfloyd removed the Status: Wont fix This will not be worked on label Apr 10, 2024
@nickfloyd nickfloyd merged commit 889bf25 into octokit:main Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Something isn't working as documented Type: Feature New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG]: Download Artifact - Content Stores Differing Content-Types Cause Errors

2 participants