Skip to content

Fixes PushId datatype to not overflow (fix user activity exception)#2844

Merged
nickfloyd merged 2 commits intooctokit:mainfrom
mitchcapper:fix_pushevent_id_overflow_pr
Jan 18, 2024
Merged

Fixes PushId datatype to not overflow (fix user activity exception)#2844
nickfloyd merged 2 commits intooctokit:mainfrom
mitchcapper:fix_pushevent_id_overflow_pr

Conversation

@mitchcapper
Copy link
Contributor

@mitchcapper mitchcapper commented Jan 3, 2024

Bug introduced in #2795 Closes #2822

Resolves #2822


Before the change?

  • Exception on any user activity with a recent PR where it exceeded Int32.maxvalue

After the change?

  • does not exception out

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

long is used elsewhere for ids, the PR just used the wrong datatype.

@nickfloyd nickfloyd added the Type: Bug Something isn't working as documented label Jan 4, 2024
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mitchcapper thanks for the contributions here! ❤️

@nickfloyd nickfloyd merged commit 9bd519f into octokit:main Jan 18, 2024
Lulalaby referenced this pull request in Fortunevale/ProjectMakoto Jan 25, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [Octokit](https://togithub.com/octokit/octokit.net) | `9.1.0` ->
`9.1.1` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/Octokit/9.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Octokit/9.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Octokit/9.1.0/9.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Octokit/9.1.0/9.1.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>octokit/octokit.net (Octokit)</summary>

###
[`v9.1.1`](https://togithub.com/octokit/octokit.net/releases/tag/v9.1.1)

#### What's Changed

##### Features

- \[feat] Add Rocket & Eyes reactions to `ReactionSummary` by
[@&#8203;Misha-133](https://togithub.com/Misha-133) in
[https://github.com/octokit/octokit.net/pull/2847](https://togithub.com/octokit/octokit.net/pull/2847)

##### Fixes

- Fixes PushId datatype to not overflow (fix user activity exception) by
[@&#8203;mitchcapper](https://togithub.com/mitchcapper) in
[https://github.com/octokit/octokit.net/pull/2844](https://togithub.com/octokit/octokit.net/pull/2844)
- Fix namespaces for Artifacts models by
[@&#8203;thomhurst](https://togithub.com/thomhurst) in
[https://github.com/octokit/octokit.net/pull/2862](https://togithub.com/octokit/octokit.net/pull/2862)

##### Maintenance

- build(deps): bump xunit from 2.6.4 to 2.6.6 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/octokit/octokit.net/pull/2853](https://togithub.com/octokit/octokit.net/pull/2853)

##### Documentation

- \[DOCS]: Removed the Related Projects Section from the `README` by
[@&#8203;wesdevpro](https://togithub.com/wesdevpro) in
[https://github.com/octokit/octokit.net/pull/2860](https://togithub.com/octokit/octokit.net/pull/2860)

#### New Contributors

- [@&#8203;Misha-133](https://togithub.com/Misha-133) made their first
contribution in
[https://github.com/octokit/octokit.net/pull/2847](https://togithub.com/octokit/octokit.net/pull/2847)
- [@&#8203;mitchcapper](https://togithub.com/mitchcapper) made their
first contribution in
[https://github.com/octokit/octokit.net/pull/2844](https://togithub.com/octokit/octokit.net/pull/2844)
- [@&#8203;wesdevpro](https://togithub.com/wesdevpro) made their first
contribution in
[https://github.com/octokit/octokit.net/pull/2860](https://togithub.com/octokit/octokit.net/pull/2860)

**Full Changelog**:
octokit/octokit.net@v9.1.0...v9.1.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Fortunevale/ProjectMakoto).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMzUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEzNS4wIiwidGFyZ2V0QnJhbmNoIjoiZGV2In0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Something isn't working as documented

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG]: GetAllUserPerformedPublic throws OverflowException

2 participants