[feat]: Adding missing properties to PushEventPayload#2795
Merged
nickfloyd merged 2 commits intooctokit:mainfrom Oct 9, 2023
Merged
[feat]: Adding missing properties to PushEventPayload#2795nickfloyd merged 2 commits intooctokit:mainfrom
nickfloyd merged 2 commits intooctokit:mainfrom
Conversation
2 tasks
nickfloyd
changed the title
nickfloyd
approved these changes
Oct 9, 2023
Contributor
nickfloyd
left a comment
nickfloyd
left a comment
There was a problem hiding this comment.
Thanks for doing this as well ❤️
mitchcapper
added a commit
to mitchcapper/octokit.net
that referenced
this pull request
Jan 3, 2024
Bug introduced in octokit#2795 Closes octokit#2822
mitchcapper
added a commit
to mitchcapper/octokit.net
that referenced
this pull request
Jan 3, 2024
Bug introduced in octokit#2795 Closes octokit#2822
4 tasks
nickfloyd
added a commit
that referenced
this pull request
Jan 18, 2024
Bug introduced in #2795 Closes #2822 Co-authored-by: Nick Floyd <[email protected]>
This was referenced Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2720
Before the change?
The
PushEventPayloadclass was missing thebefore,distinct_size, andpush_idproperties documented at https://docs.github.com/en/webhooks-and-events/events/github-event-types#pusheventAfter the change?
Those three properties are added to the
PushEventPayloadclass asDistinctSize,PushId, andBefore.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!