Skip to content

Removing empty object paramater in MigrationsClient.DeleteArchive #2698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kfcampbell merged 3 commits into from
Apr 14, 2023
Merged

Removing empty object paramater in MigrationsClient.DeleteArchive #2698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79eee56
Removing empty object paramater in MigrationsClient.DeleteArchive
gitasaurus Apr 13, 2023
f2e4b0c
Merge branch 'main' into main
kfcampbell Apr 14, 2023
5220822
Merge branch 'main' into main
kfcampbell Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Octokit.Tests/Clients/MigrationsClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,7 @@ public void RequestsCorrectUrl()
client.DeleteArchive("fake", 69);

connection.Received().Delete(
Arg.Is<Uri>(u => u.ToString() == "orgs/fake/migrations/69/archive"),
Arg.Any<object>());
Arg.Is<Uri>(u => u.ToString() == "orgs/fake/migrations/69/archive"));
}

[Fact]
Expand Down
2 changes: 1 addition & 1 deletion Octokit/Clients/MigrationsClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ public Task DeleteArchive(string org, int id)

var endpoint = ApiUrls.EnterpriseMigrationArchive(org, id);

return ApiConnection.Delete(endpoint, new object());
return ApiConnection.Delete(endpoint);
}

/// <summary>
Expand Down