Skip to content

Removing empty object paramater in MigrationsClient.DeleteArchive#2698

Merged
kfcampbell merged 3 commits intooctokit:mainfrom
gitasaurus:main
Apr 14, 2023
Merged

Removing empty object paramater in MigrationsClient.DeleteArchive#2698
kfcampbell merged 3 commits intooctokit:mainfrom
gitasaurus:main

Conversation

@gitasaurus
Copy link
Contributor

@gitasaurus gitasaurus commented Apr 13, 2023

Resolves #2697


Behavior

Before the change?

  • MigrationsClient.DeleteArchive throws an ArgumentException - The value cannot be null or empty. (Parameter 'mediaType') when invoked in an application compiled using .Net 7.0

After the change?

  • MigrationsClient.DeleteArchive succeeds on .Net 7.0.

Other information

  • Requires modifying Octokit.Tests/Clients/MigrationsClientTests.cs (any object was required by the test, hence the new object() parameter being added to pass the test)

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

Copy link
Contributor

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kfcampbell kfcampbell merged commit a3299ac into octokit:main Apr 14, 2023
Lulalaby referenced this pull request in Fortunevale/ProjectMakoto Apr 28, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [Octokit](https://togithub.com/octokit/octokit.net) | nuget | minor |
`5.0.4` -> `5.1.0` |

---

### Release Notes

<details>
<summary>octokit/octokit.net</summary>

###
[`v5.1.0`](https://togithub.com/octokit/octokit.net/releases/tag/v5.1.0)

#### What's Changed

##### Features

- Allow users to fetch all commits for two commits comparison by
[@&#8203;zolroman](https://togithub.com/zolroman) in
[https://github.com/octokit/octokit.net/pull/2690](https://togithub.com/octokit/octokit.net/pull/2690)
- Added missing 'container' property in metadata on a package version.
by [@&#8203;thomaslem](https://togithub.com/thomaslem) in
[https://github.com/octokit/octokit.net/pull/2696](https://togithub.com/octokit/octokit.net/pull/2696)
- Self-hosted runners and Self-hosted runner groups APIs by
[@&#8203;lineville](https://togithub.com/lineville) in
[https://github.com/octokit/octokit.net/pull/2695](https://togithub.com/octokit/octokit.net/pull/2695)

##### Fixes

- Removing empty object parameter in MigrationsClient.DeleteArchive by
[@&#8203;gitasaurus](https://togithub.com/gitasaurus) in
[https://github.com/octokit/octokit.net/pull/2698](https://togithub.com/octokit/octokit.net/pull/2698)

#### New Contributors

- [@&#8203;zolroman](https://togithub.com/zolroman) made their first
contribution in
[https://github.com/octokit/octokit.net/pull/2690](https://togithub.com/octokit/octokit.net/pull/2690)
- [@&#8203;thomaslem](https://togithub.com/thomaslem) made their first
contribution in
[https://github.com/octokit/octokit.net/pull/2696](https://togithub.com/octokit/octokit.net/pull/2696)
- [@&#8203;gitasaurus](https://togithub.com/gitasaurus) made their first
contribution in
[https://github.com/octokit/octokit.net/pull/2698](https://togithub.com/octokit/octokit.net/pull/2698)
- [@&#8203;lineville](https://togithub.com/lineville) made their first
contribution in
[https://github.com/octokit/octokit.net/pull/2695](https://togithub.com/octokit/octokit.net/pull/2695)

**Full Changelog**:
octokit/octokit.net@v5.0.4...v5.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/Fortunevale/ProjectMakoto).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS42My4xIiwidXBkYXRlZEluVmVyIjoiMzUuNjMuMSJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG]: .NET 7.0 causes ArgumentException in Migrations.DeleteArchive

2 participants