Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions Octokit.Tests/Helpers/StringExtensionsTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -89,5 +89,30 @@ public void EscapeDoubleQuotesEscapesAllDoubleQuotes()
Assert.Equal("\\\"test milestone\\\"", input.EscapeDoubleQuotes());
}
}

public class EncodeSharpMethod
{
[Fact]
public void EncodeSharpReturnsNullForNullInput()
{
Assert.Equal(string.Empty, (null as string).EncodeSharp());
}

[Fact]
public void EncodeSharpReturnsInputWithoutDoubleQuotes()
{
string input = "some test input without double quotes in it";

Assert.Equal(input, input.EncodeSharp());
}

[Fact]
public void EncodeAllSharp()
{
string input = "#some test input with # in it#";

Assert.Equal("%23some test input with %23 in it%23", input.EncodeSharp());
}
}
}
}
8 changes: 7 additions & 1 deletion Octokit/Helpers/StringExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,9 @@ public static bool IsNotBlank(this string value)
public static Uri FormatUri(this string pattern, params object[] args)
{
Ensure.ArgumentNotNullOrEmptyString(pattern, nameof(pattern));
var uriString = string.Format(CultureInfo.InvariantCulture, pattern, args).EncodeSharp();

return new Uri(string.Format(CultureInfo.InvariantCulture, pattern, args), UriKind.Relative);
return new Uri(uriString, UriKind.Relative);
}

public static string UriEncode(this string input)
Expand Down Expand Up @@ -106,6 +107,11 @@ internal static string EscapeDoubleQuotes(this string value)
return value;
}

internal static string EncodeSharp(this string value)
{
return !string.IsNullOrEmpty(value) ? value?.Replace("#", "%23") : string.Empty;
}

static IEnumerable<string> SplitUpperCase(this string source)
{
Ensure.ArgumentNotNullOrEmptyString(source, nameof(source));
Expand Down