Skip to content

Fixed a bug that content cannot be retrieved if "#" is included in a file or folder name. #2608

Merged
nickfloyd merged 7 commits intooctokit:mainfrom
minoura-a:fix-2587
Nov 23, 2022
Merged

Fixed a bug that content cannot be retrieved if "#" is included in a file or folder name. #2608
nickfloyd merged 7 commits intooctokit:mainfrom
minoura-a:fix-2587

Conversation

@minoura-a
Copy link
Contributor

I have confirmed that content can be retrieved even if "#" is included in the file or folder name.
I have confirmed that all unit tests passed.
#2587

@minoura-a minoura-a changed the title Fixed a bug that content cannot be retrieved if "#" is included in a file or folder name. #2587 Fixed a bug that content cannot be retrieved if "#" is included in a file or folder name. Nov 8, 2022
@kfcampbell
Copy link
Contributor

@minoura-a nice work! Would you mind adding tests for the new helper you created to match those here?

@minoura-a
Copy link
Contributor Author

@kfcampbell
Thank you for confirming this.
I will create a test, please wait a couple of days.

@minoura-a
Copy link
Contributor Author

minoura-a commented Nov 10, 2022

@kfcampbell
Since the EncodeSharp method is only used within the StringExtensions class, the accessibility of the method has been changed to private.
This is a Commit.
For this reason, I do not believe testing is necessary.
Or, I may need additional testing of the FormatUri method that uses this method.

@kfcampbell
Copy link
Contributor

I think it's still worthwhile to create a test for this behavior, similar to the one for EscapeDoubleQuotes.

@minoura-a
Copy link
Contributor Author

@kfcampbell
I have created a test. Could you confirm it?
This is a commit.

@nickfloyd nickfloyd added Priority: Normal Type: Bug Something isn't working as documented labels Nov 14, 2022
@minoura-a
Copy link
Contributor Author

@kfcampbell
I seem to be failing the Sourcelink test, is there anything I should do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Something isn't working as documented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants