Skip to content

Package naboris.0.0.8 #15629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shawn-mcginty wants to merge 1 commit into from
Closed

Package naboris.0.0.8 #15629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions packages/naboris/naboris.0.0.8/opam
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
opam-version: "2.0"
synopsis: "Simple http server"
description: "Simple http server built on httpaf and lwt"
maintainer: "Shawn McGinty <[email protected]>"
authors: [ "Shawn McGinty <[email protected]>" ]
license: "MIT"
homepage: "https://github.com/shawn-mcginty/naboris"
bug-reports: "https://github.com/shawn-mcginty/naboris/issues"
dev-repo: "git+https://github.com/shawn-mcginty/naboris.git"
build: [
["dune" "subst"] {pinned}
["dune" "build" "-p" name "-j" jobs]
]
depends: [
"ocaml" {>= "4.05.0"}
"dune" {build}
Copy link
Member

@kit-ty-kate kit-ty-kate Jan 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"dune" {build}
"dune" {>= "1.6"}

Dune should not be tagged as a build dependency (see #14266), moreover your dune-project file says this package requires at least dune 1.6

"reason" {>= "3.4.0"}
"httpaf" {>= "0.6.0"}
"httpaf-lwt-unix" {>= "0.6.0"}
"lwt" {>= "4.2.1"}
"uri" {>= "2.2.0"}
"bisect_ppx" {build}
Copy link
Member

@kit-ty-kate kit-ty-kate Jan 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"bisect_ppx" {build}
"bisect_ppx" {dev}

According to what I could find in the documentation of bisect_ppx this should not be tagged as a build dependency either (has a runtime dependency) and can be avoided in most cases except for devs (thus the dev tag, from the documentation)

]
url {
src: "https://github.com/shawn-mcginty/naboris/archive/0.0.8.tar.gz"
checksum: [
"md5=696fba999dd624d1b023020fd58e7588"
"sha512=0867c1d883ef40ec19e6f7045ab784a04d3fb068d0449d3a5cb21f00918f75e07222d56d98077ab067d3d3c5c561c4c37dde94c693a55b22de2f0de251014875"
]
}