Package naboris.0.0.8 #15629
Closed
Package naboris.0.0.8 #15629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Commit: f48c9b4 @shawn-mcginty has posted 7 contributions. ☀️ All lint checks passed f48c9b4
☀️ Installability check (+1)
|
kit-ty-kate
reviewed
Jan 5, 2020
| ] | ||
| depends: [ | ||
| "ocaml" {>= "4.05.0"} | ||
| "dune" {build} |
Member
There was a problem hiding this comment.
Suggested change
| "dune" {build} | |
| "dune" {>= "1.6"} |
Dune should not be tagged as a build dependency (see #14266), moreover your dune-project file says this package requires at least dune 1.6
kit-ty-kate
reviewed
Jan 5, 2020
| "httpaf-lwt-unix" {>= "0.6.0"} | ||
| "lwt" {>= "4.2.1"} | ||
| "uri" {>= "2.2.0"} | ||
| "bisect_ppx" {build} |
Member
There was a problem hiding this comment.
Suggested change
| "bisect_ppx" {build} | |
| "bisect_ppx" {dev} |
According to what I could find in the documentation of bisect_ppx this should not be tagged as a build dependency either (has a runtime dependency) and can be avoided in most cases except for devs (thus the dev tag, from the documentation)
Contributor
Author
|
I will implement reviewer changes in the next version, I have a bunch of changes I want to publish anyway :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
naboris.0.0.8Simple http server
Simple http server built on httpaf and lwt
🐫 Pull-request generated by opam-publish v2.0.0