[new release] fiat-p256 (0.2.0) #14572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGES: *2019-07-23* ### Fixed - Fix a bug in `generate_key` where it would never actually work when used with a proper `rng` function (mirage/fiat#44, @NathanReb) - Fix benchmark executable. It is now built (but not executed) as part of tests (mirage/fiat#45, @emillon) ### Changed - Use `alcotest` instead of `ppx_expect` for tests (mirage/fiat#43, @emillon)
Contributor
☀️ All lint checks passed 661f5b3
☀️ Installability check (+1)
|
kit-ty-kate
reviewed
Jul 23, 2019
kit-ty-kate
reviewed
Jul 23, 2019
Member
|
Otherwise it's all good |
Co-Authored-By: Kate <[email protected]>
Co-Authored-By: Kate <[email protected]>
Contributor
Author
|
All refreshed @kit-ty-kate ! |
Member
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primitives for Elliptic Curve Cryptography taken from Fiat
CHANGES:
2019-07-23
Fixed
generate_keywhere it would never actually work when used witha proper
rngfunction (Fix generate_key mirage/fiat#44, @NathanReb)(Build bench executable in tests mirage/fiat#45, @emillon)
Changed
alcotestinstead ofppx_expectfor tests (Remove ppx_expect dependency mirage/fiat#43, @emillon)