Skip to content
This repository was archived by the owner on Apr 23, 2021. It is now read-only.

Conversation

@emillon
Copy link
Collaborator

@emillon emillon commented Jul 23, 2019

But do not run it. This ensures that it breaks if the API changes.

@emillon emillon requested a review from NathanReb July 23, 2019 08:06
@emillon emillon self-assigned this Jul 23, 2019
@emillon emillon merged commit 3acf449 into mirage:master Jul 23, 2019
@emillon emillon deleted the build-bench branch July 23, 2019 11:55
emillon added a commit to emillon/opam-repository that referenced this pull request Jul 23, 2019
CHANGES:

*2019-07-23*

### Fixed

- Fix a bug in `generate_key` where it would never actually work when used with
  a proper `rng` function (mirage/fiat#44, @NathanReb)
- Fix benchmark executable. It is now built (but not executed) as part of tests
  (mirage/fiat#45, @emillon)

### Changed

- Use `alcotest` instead of `ppx_expect` for tests (mirage/fiat#43, @emillon)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant